Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k_fold_cross_validationshuffles index labels and reindexes the dataset. A DataFrame formed by concatenating cohorts without resetting the index raisesValueError: cannot reindex on an axis with duplicate labels. If every label is identical, the shuffle silently leaves rows in their original order.Shuffle row positions with
ilocinstead. This preserves labels while assigning the same folds for the same rows and seed, regardless of their index. Regression tests compare fold scores against the original RangeIndex for repeated labels, a constant string index and a non-unique MultiIndex, and check that the input is unchanged.Validation: all three new parameterized cases fail on the original implementation; the complete utility module passes after the fix (92 passed, two approximation warnings). Python 3.12.14, NumPy 2.5.4, pandas 2.3.3, lifelines 0.30.3. Repository-pinned Black 22.8.0 reports formatting differences in unchanged baseline sections of both files; its diff does not touch the new regression or changed shuffle line. git diff --check passes. The full model suite was not run.