Preserve variable names in translator-produced code #1300
Merged
+31
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the translator renamed all variables using generic patterns like v1, v2, v3 (or x1, x2, x3), discarding the original names from the shallow embedding. This made generated code harder to read and debug. Now variable names include the original name as a suffix, producing names like v1_foo, v2_bar. For pattern-matched arguments that aren't simple variables, the old vN naming is retained as a fallback. Addresses issue #12. Co-Authored-By: Claude <[email protected]>
The previous change to preserve variable names was incorrectly preserving names from intermediate renaming passes (using the " variable " prefix with spaces). This produced malformed names like "v1_ variable 1_foo". Fix by detecting names containing spaces and not appending them, since real source variable names cannot contain spaces. Co-Authored-By: Claude <[email protected]>
myreen
reviewed
Jan 10, 2026
Contributor
myreen
left a comment
myreen
left a comment
There was a problem hiding this comment.
It's a bit risky to change a name such as x' to v4_x' because the translator eagerly removes trailing primes. This means that it can in some subterm change v4_x' to v4_x which might not match what's in a different subterm.
A safer option would be to make the new names be v4_x'_ or some other format that doesn't have the original name directly as a suffix.
To prevent stripping of primes in the original name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the translator renamed all variables using generic patterns like v1, v2, v3 (or x1, x2, x3), discarding the original names from the shallow embedding. This made generated code harder to read and debug.
Now variable names include the original name as a suffix, producing names like v1_foo, v2_bar. For pattern-matched arguments that aren't simple variables, the old vN naming is retained as a fallback.
Addresses issue #12.