Revised floats #1210
Merged
Revised floats #1210
+2,359
−32,182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this brave new world, floats are just Word64s, with the operations defined over Word64 literal values.
Need to get expert advice on typing of values in typeSoundInvariantScript.sml.
Also cleanup files a bit, removing old stuff and/or moving some float ast things into astScript.sml
In particular, define (new) operators in flat corresponding to FpFromWord and FpToWord because we are keeping Float64 literals in flat as we had them in source.
In particular, use new FLOAT64 relation instead of WORD when translating f.p. operators.
Then fix the breakage in inference soundness.
This is being retired because it has turned out to be too costly to maintain for on-going and planned changes to CakeML.
Contributor
Author
|
I'm working on getting the merge to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty confident this is building against
masterbut hope that making the PR will prompt the regression machinery to check.The essence of the change is the removal of real numbers, fpOptimise and fp/real-trees from the semantics. There are knock-on effects down to
closbecauseflatuses the semantics operations and those have changed.closkeeps its existing operations, so nothing below there needs changing.