Skip to content

Simplify Pancake parse tree conversion for progs #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myreen merged 1 commit into from
Jun 29, 2025
Merged

Simplify Pancake parse tree conversion for progs #1188

myreen merged 1 commit into from
Jun 29, 2025

Conversation

@halogentlepersuasion
Copy link
Contributor

@halogentlepersuasion halogentlepersuasion commented Jun 19, 2025 •
edited
Loading

  • Currently, when a ProgNT not found for function bodies, variable declarations, handler bodies, conditional branches and loops, a Skip is inserted during parse tree conversion, which requires considering the length of the parse tree
  • Now, the Skip is inserted at the parsing stage which means only one length of parse tree needs to be considered during conversion

@myreen myreen merged commit 26fdfd0 into CakeML:master Jun 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@halogentlepersuasion @myreen