Adding <cstdint> includes to allow building with gcc13#856
Merged
rob-p merged 7 commits intoCOMBINE-lab:developfrom Jun 26, 2023
A-N-Other:patch-1
Merged
Adding <cstdint> includes to allow building with gcc13#856rob-p merged 7 commits intoCOMBINE-lab:developfrom A-N-Other:patch-1
rob-p merged 7 commits intoCOMBINE-lab:developfrom
A-N-Other:patch-1
Conversation
Merge develop -> master
SalmonExceptions.hpp: add include
SalmonConfig.hpp: add include
Collaborator
|
Thanks @A-N-Other! I changed the base branch to develop, as we generally pull everything through that branch before it makes it to master. Otherwise, these changes look good. Hopefully we'll get around to pushing out a patch release with this change soon. |
Contributor
Author
|
Happy to help! Have just been patching for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://gcc.gnu.org/gcc-13/porting_to.html,
gcc13changes the way it handles includes. These three files needed patching to allow the build to work.