Custom fields not available as repeatable #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat extends `CMB2_Type_Base`. This was causing custom fields available through the `cmb2_render_{$field_type}` action hook to not be repeatable.
Member
|
This looks like a possible fix, but I will need to test for side-effects. Are you familiar with unit tests? It would be good to write a unit test that verifies this functionality is broken until this patch is applied. |
Contributor
Author
|
I am. I will try to write some this week. Good suggestion. 👍 |
Contributor
|
Any updates on this? |
jtsternberg
added a commit
that referenced
this pull request
Jul 7, 2017
jtsternberg
added a commit
that referenced
this pull request
Jul 7, 2017
Member
|
Thanks for this @desrosj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.2.4, a bug was introduced where custom fields were not available as a repeatable field. This was only happening to fields that were added using the
cmb2_render_{$field_type}action hook. Fields rendered by a class extendingCMB2_Type_Baseclass were unaffected by this.Currently, the
maybe_custom_field_objectalways returns the $type property. This is causing the__call()function to never reach thecmb2_render_{$field_type}action hook.This pull fixes #901, and improves the PHPDocblock for the function.