Update "Image" Definition#874
Closed
kuchenundkakao wants to merge 2 commits intoCMB2:trunkfrom
kuchenundkakao:patch-1
Closed
Update "Image" Definition#874kuchenundkakao wants to merge 2 commits intoCMB2:trunkfrom kuchenundkakao:patch-1
kuchenundkakao wants to merge 2 commits intoCMB2:trunkfrom
kuchenundkakao:patch-1
Conversation
If SVG Upload is enabled, SVG can't be chosen in file_list Field because it is MIME-Type "image", but doesn't have Size Data.
Member
|
There needs to be another way to determine this. Currently, this PR causes images to be processed as files: http://b.ustin.co/lg5j |
Author
|
yeah sorry, i thought i could use the wp global methods. Replaced it with a check for the svg extension for now. |
Member
|
Played with this a bit. I think it would be more ideal to use the svg as an image and output the preview (and workaround the "size" checks). |
Member
|
Please test this branch as I've attempted to fix the svg image display: https://github.com/WebDevStudios/CMB2/tree/fix-svg-display |
Author
|
Yep, Works ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If SVG Upload is enabled, SVG can't be chosen in file_list Field because it is MIME-Type "image", but doesn't have Size Data.