Fixed object-type detection of the CMB2::current_object_type() method#842
Merged
jtsternberg merged 1 commit intoCMB2:trunkfrom Jan 20, 2017
Merged
Fixed object-type detection of the CMB2::current_object_type() method#842jtsternberg merged 1 commit intoCMB2:trunkfrom
CMB2::current_object_type() method#842jtsternberg merged 1 commit intoCMB2:trunkfrom
Conversation
to handle the 'add-tag' action of the 'admin-ajax.php' page.
Member
|
This is great, and the bug report, steps for reproducing, etc were all very clear, and the PR is focused. This makes for an easy merge. Thank you! |
jtsternberg
added a commit
that referenced
this pull request
Jan 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to handle the 'add-tag' action of the 'admin-ajax.php' page.
Fixes #841.
Changes proposed in this pull request
admin-ajax.phpand if an action parameter exists within the $_POST variable determine object-type based on it's value.PS: AFAICT, there is only one entry point into the plugin's execution flow via the 'admin-ajax.php' page and this applies to this specific scenario / term object-type therefore the action parameter validation is sort of useless however, perhaps this might change in the near future so I'm recommending we leave it there.