Context location setup #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing. May need to fix on the frontend
norcross
commented
Jan 17, 2017
includes/CMB2_hookup.php
Outdated
| $classes = 'postbox context-' . $cmb->prop( 'context' ) . '-box context-box '; | ||
| $classes .= in_array( $cmb->cmb_id, $hidden ) ? ' hide-if-js' : ''; | ||
| $classes .= postbox_classes( $cmb->cmb_id, $screen->id ); | ||
| $classes = 'postbox context-' . $this->cmb->prop( 'context' ) . '-box context-box postbox-container '; |
Collaborator
Author
There was a problem hiding this comment.
why did you add the postbox-container class as well?
Member
There was a problem hiding this comment.
The postbox-container class was being used to style the field rows, but I refactored it a bit so that it's not needed. You can see those changes in Update context metabox output to handle no-title or no-wrap better
norcross
commented
Jan 17, 2017
includes/CMB2_hookup.php
Outdated
| // Call our before hook. | ||
| if ( ! empty( $this->cmb->prop( 'title' ) ) ) { | ||
| $this::context_box_title_markup_open( $this->cmb ); | ||
| $this->context_box_title_markup_open( $this->cmb ); |
Collaborator
Author
There was a problem hiding this comment.
if you're not going to use the $cmb variable passed in the function, can be removed from here
jtsternberg
added a commit
that referenced
this pull request
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request