Conversation
… in the post editor.
jtsternberg
left a comment
jtsternberg
left a comment
There was a problem hiding this comment.
As discussed, this looks good. I left a couple comments/questions inline. Let me know if you have any questions.
includes/CMB2_hookup.php
Outdated
| return $classes; | ||
| } | ||
|
|
||
| // Include a generic context wrapper and the postbox wrapper. |
There was a problem hiding this comment.
Unless you have a specific reason, I think i'll nix the postbox class.
There was a problem hiding this comment.
the postbox class ensures it looks like the other metaboxes. I can create a conditional if you'd prefer.
There was a problem hiding this comment.
@norcross makes sense. I think I was seeing it cached, so it looked a little wonky. What do you think about outputting the entire metabox markup, allowing "metaboxes" in those other locations? (let's not worry about that for now)
|
|
||
| if ( ! $this->show_on() ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think we'll probably need to check if the we're looking at the right post-type before we output the form. See the post-type loop in CMB2_hookup::add_metaboxes().
…ion instead of using the filter. including the post type check for calling the form
|
💥 thank you Mr. @norcross! |
2 participants
Changes proposed in this pull request
extending the use of the
contextarg to allow for placement in other locations inside the post editor. new areas:edit_form_topactionedit_form_before_permalinkactionedit_form_after_titleactionedit_form_after_editoraction