Fixed undefined variable: page_type #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You're missing $page_type variable :)
Contributor
|
Not quite sure what this is supposed to fix, to be honest. The original version in the line changed would return a value right away. All you're ending up doing is assigning that to a variable, inside an if statement. Never been a fan of variable assignment inside if statements myself. Is this fixing an open issue at all? or just casual looking over of the code? |
Contributor
Author
|
You can look |
Contributor
|
Gotcha. |
Member
|
Thank you sir. |
Contributor
Author
|
You're welcome :) |
jtsternberg
added a commit
that referenced
this pull request
Oct 25, 2016
jtsternberg
added a commit
that referenced
this pull request
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're missing $page_type variable :)