update files to be PHP7 compatible #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add <?php opening tag to empty files Rename function that is a reserved keyword
Contributor
|
Looks good to me, for the most part. Ran ack on the code and you covered any cases of using the "string()" method, however others who may be using that method will need to update as well. Only real blocker I can find. Up to Justin to approve though. |
jtsternberg
added a commit
that referenced
this pull request
Aug 23, 2016
Member
|
Merged. I've added a back-compat shim if anyone is using the |
Contributor
Author
|
Thanks @jtsternberg and @tw2113! |
Member
|
Thank you, sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719 .
Changes proposed in this pull request
CMB_Field->string()function toCMB_Field->get_string()(string is a reserved keyword in PHP 7.0)