Field comments #675
Merged
Field comments #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed in testing that the result can be bool, int, or occasionally array
Noticed in testing that the result can be bool, int, or occasionally array
Argh, too many 8 year old kids running around distracting me
|
Hmm, why did you add |
|
When I was debugging it returns the value of update_metadata which can be false, the meta ID of the object, and in some weird case it was actually an array. I'll have to trace back when I have a chance to see why it would be an array |
|
@jamesgol nah, no need, I didn't dig that deep in to |
|
The 'test_get_oembed_delete_with_expired_ttl' test gets a return of an array. Looks like the remove_data() function is returning an array, that doc probably needs updated too |
|
I'll take any doc updates you want to send. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.