Make the Title field type handles extra args #656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2016 09:38
Currently, the Title type didn't take into consideration extra arguments like 'attributes'. Now it does.
Member
|
Nice catch. Remove the |
includes/types/CMB2_Type_Title.php
Outdated
|
|
||
| return $this->rendered( | ||
| sprintf( '<%1$s class="%2$s">%3$s</%1$s>%4$s', $a['tag'], $a['class'], $a['name'], $a['desc'] ) | ||
| sprintf( '<%1$s %2$s/>%3$s</%1$s>%4$s', $a['tag'], $this->concat_attrs( $a, array( 'tag', 'name', 'desc' ) ), $a['name'], $a['desc'] ) |
Member
There was a problem hiding this comment.
why is there an extra forward slash before %3$s?
Author
|
I have removed the $args and the slash. Keep up the good work. |
Member
|
Thanks. Still a no-go. You don't need to pass the |
Author
|
Damn. Ok. Removed it for good now. |
jtsternberg
added a commit
that referenced
this pull request
Jun 3, 2016
…ixelgrade/trunk. Squashed commit of the following: commit d3dad17ad8a97c50134dcb865b47cf4920458239 Author: Justin Sternberg <[email protected]> Date: Fri Jun 3 13:52:49 2016 -0400 Clean up commit 8b94b02 Author: Vlad Olaru <[email protected]> Date: Fri Jun 3 10:30:49 2016 +0300 Removed the $args for good commit 09e83ff Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 21:29:31 2016 +0300 Removed the $args and bad slash for the title field commit c6c2b1f Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 09:52:13 2016 +0300 Added PHPDoc for the title type render function commit 1e6369d Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 09:38:14 2016 +0300 Make the Title type handle extra args Currently, the Title type didn't take into consideration extra arguments like 'attributes'. Now it does.
jtsternberg
added a commit
that referenced
this pull request
Jun 3, 2016
…ixelgrade/trunk. Squashed commit of the following: commit d3dad17ad8a97c50134dcb865b47cf4920458239 Author: Justin Sternberg <[email protected]> Date: Fri Jun 3 13:52:49 2016 -0400 Clean up commit 8b94b02 Author: Vlad Olaru <[email protected]> Date: Fri Jun 3 10:30:49 2016 +0300 Removed the $args for good commit 09e83ff Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 21:29:31 2016 +0300 Removed the $args and bad slash for the title field commit c6c2b1f Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 09:52:13 2016 +0300 Added PHPDoc for the title type render function commit 1e6369d Author: Vlad Olaru <[email protected]> Date: Thu Jun 2 09:38:14 2016 +0300 Make the Title type handle extra args Currently, the Title type didn't take into consideration extra arguments like 'attributes'. Now it does.
Member
|
A bit of cleanup and this is merged: c171812 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Title type didn't take into consideration extra arguments like 'attributes'. Now it does, just like the rest of the fields. This will allow for add-ons like CMB2-conditionals to work for this field type also.