use dev instead of v1 for phpcompatibility-action
#1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like 8.0 is giving us the most errors, and 8.1 and 8.2 are not giving additional feedback. Additionally, 8.0 is giving notices for 8.1 so this is probably the best thing to check against right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the
devbranch of thephpcompatibility-actionrather than thev1Motivation and Context
v1uses the stable, 9.3 version of the PHPCompatibility sniffs, however that version does not include any 8.x checks, so running8.x-doesn't check anything valuable.The
devbranch of the action pulls thedevelopbranch of PHPCompatibility, which does include 8.x sniffs.Risk Level
minimal (although we should get errors for PHP 8.x compatibility)
Testing procedure
Should be evident in the tests...
Types of changes
Checklist: