Bug Fix - CMB2_Type_Multi_Base.php #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents deprecation notice: Deprecated: Required parameter $i follows optional parameter $args in /../vendor/cmb2/cmb2/includes/types/CMB2_Type_Multi_Base.php on line 34
Contributor
Author
|
Just got this deprecation notice, so I am checking the rest of the code for similar issues. |
carloswph
changed the title
Contributor
|
Unsure how much backwards compatibility this may introduce, though at least for CMB2 core, all uses pass a counter for this method. Given that it's been a required value, I am assuming everyone is passing something. So, I'm fine with that, but as always want any final concerns checked by @jtsternberg as well. |
carloswph
changed the title
jtsternberg
reviewed
Apr 7, 2021
…pes::_id, which is where this $i argument is used.
Member
|
Thanks! |
|
Is there any chance to release this fix in the next future? |
Contributor
|
Since it got merged, I believe it will be part of the next release. Just a question of when the release will happen, at this point. |
Member
|
Just pushed a release. 2.10.0 https://wordpress.org/plugins/cmb2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents deprecation notice:
Deprecated: Required parameter $i follows optional parameter $args in /../vendor/cmb2/cmb2/includes/types/CMB2_Type_Multi_Base.php on line 34
Description
Motivation and Context
Fixes #{issue-number}.
Risk Level
Testing procedure
Types of changes
Checklist:
Screenshots