initial 5.3 styling prep work #1314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the most pressing issues related to 5.3 admin CSS changes.
Description
Mostly involves input and button heights being messed up due to a change in padding, min-height philosophy core has made in the interest of accessibility.
Risk Level
Minimal, I believe.
Testing procedure
Tested using fields from
example-functions.phpin WordPress 5.2 and 5.3.Checklist:
Screenshots
Taken with Classic Editor enabled because the Block Editor makes full-page screenshots super hard. The only difference I found between Block and Classic editor were the way they handled styling for the dot inside radio buttons in 5.3+. I have a fix that accommodates both in
_main-wrap.scss5.2 before: http://galen.in/PGA6D9
5.2 after: http://galen.in/ddMXHc
5.3 before: http://galen.in/wtamxE
5.3 after: http://galen.in/2DXIdX