Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the return of CMB2->box_classes() in sanitize_html_class() per VIP Feedback #1255

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Wrap the return of CMB2->box_classes() in sanitize_html_class() per VIP Feedback #1255

merged 1 commit into from
Apr 12, 2019

Conversation

kevinlangleyjr
Copy link
Contributor

Description

Wrapping the return of CMB2->box_classes() in sanitize_html_class() per WP VIP Feedback.

Motivation and Context

Sanitizes the class of the CMB2 box.

Risk Level

Minimal risk

Testing procedure

  1. Add filter to cmb2_wrap_classes to add some class names with quotes or special characters.
  2. Create CMB2 metabox.
  3. Check CMB2 metabox classes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@tw2113 tw2113 merged commit db0e15f into CMB2:develop Apr 12, 2019
@tw2113
Copy link
Contributor

tw2113 commented Apr 12, 2019

This one looks like it'd be a good last moment extra cleanup check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlangleyjr @tw2113