Don't exclude composer.json from the distribution #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
Member
|
I’d like to switch this as you mention and instead exclude the lock file. If you’re able to add that, great. If not, I can when I get to this. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installing CMB2 via Composer, the composer.json file gets excluded from the package. While this file isn't strictly needed, it helps if this file is in place when you're checking dependencies in your project.
In addition, the composer.lock file doesn't get excluded, which is weird.
Motivation and Context
After installing CMB2 via Composer, I wanted to quickly check its dependencies but was unable to do so.
Risk Level
Low
Testing procedure
mkdir composer-export && git archive HEAD | tar -xC composer-exportcomposer-exportdirectoryTypes of changes
Checklist: