Skip to content

Conversation

@tw2113
Copy link
Contributor

@tw2113 tw2113 commented Oct 19, 2018

Creating a PR simply for re-review before merge.

Lots of PHPCS cleanup in the includes folder.

@tw2113 tw2113 merged commit d797a8d into trunk Oct 20, 2018
@tw2113 tw2113 deleted the qa/phpcs-cleanup branch October 20, 2018 05:31
jtsternberg added a commit that referenced this pull request Oct 22, 2018
lipemat added a commit to lipemat/CMB2 that referenced this pull request Nov 12, 2018
* trunk:
  Fix PR urls in changelog
  Add props for CMB2#1179
  Qa/phpcs cleanup (CMB2#1179)
  add our minimum required php version to the readme
  Update changelong to give props for CMB2#1177
  Another instance where we should use call_user_func() instead of direct call
  use call_user_func() instead of direct call.
  Add 3 custom field types from @scottsawyer to readme resources. Closes CMB2#1171
  update some more 3rd party resource items
  cleanup phpdocs for `php_to_js_dateformat`
  update 3rd party resources to include Leaflet Map field type. Props @villeristi
  Minor correction in URL
  Added new custom field type
  Tweak inline comments, and update changelog to give props for CMB2#1166
  Add CMB2_Field::get_rest_value method for sending value through several filters before sending to REST request
  WP_Http class constants were added in WP 4.5
  Doing it CMB2 way
  Fix the issue in WP prior to 4.7
  Add Switch Button field type to resources. Closes CMB2#1151
lipemat added a commit to lipemat/CMB2 that referenced this pull request Nov 12, 2018
* master:
  Fix PR urls in changelog
  Add props for CMB2#1179
  Qa/phpcs cleanup (CMB2#1179)
  add our minimum required php version to the readme
  Update changelong to give props for CMB2#1177
  Another instance where we should use call_user_func() instead of direct call
  use call_user_func() instead of direct call.
  Add 3 custom field types from @scottsawyer to readme resources. Closes CMB2#1171
  update some more 3rd party resource items
  cleanup phpdocs for `php_to_js_dateformat`
  update 3rd party resources to include Leaflet Map field type. Props @villeristi
  Minor correction in URL
  Added new custom field type
  Tweak inline comments, and update changelog to give props for CMB2#1166
  Add CMB2_Field::get_rest_value method for sending value through several filters before sending to REST request
  WP_Http class constants were added in WP 4.5
  Doing it CMB2 way
  Fix the issue in WP prior to 4.7
  Add Switch Button field type to resources. Closes CMB2#1151
  make remove_default_tax_metaboxes method public so it may be called by hooks
  Call remove_default_tax_metaboxes from any type of post_hooks
  Call remove_default_tax_metaboxes from any type of post_hooks
  Add Props for CMB2#1142
  Update the draggable state's border style
  support drag sorting for groups
  Fix docblock for CMB2_Type_Base::__call
lipemat added a commit to lipemat/CMB2 that referenced this pull request Jul 19, 2019
…ng-for-groups

* upstream/trunk:
  Add props for CMB2#1147
  Some additional cleanup on CMB2#1147
  Add props for CMB2#1187
  Pull in the nodename, and default to div
  Make field description color accessible (fix color contrast ratio). h/t @rianrietveld. Fixes CMB2#1193
  Add optional mb_callback_args box property which allows defining args for add_meta_box. Closes CMB2#1191
  Update changelong to give @staurand props for CMB2#1190 (Fixes CMB2#1156)
  Revert file changes from CMB2#1190 and move gutenberg compatibility callback to main cmb JS file
  Update assets
  Fix tests: add cmb2-wysiwyg-gutenberg-fix as js dependency
  Fix CMB2#1156 / Update Gruntfile
  Fix CMB2#1156
  Updates 1187 - explicitly specifiy closing bracket when adding a new row to group
  support any type of markup when repeating group row
  Fix PR urls in changelog
  Add props for CMB2#1179
  Qa/phpcs cleanup (CMB2#1179)
  add our minimum required php version to the readme
  Update changelong to give props for CMB2#1177
  Another instance where we should use call_user_func() instead of direct call
  use call_user_func() instead of direct call.
  Add 3 custom field types from @scottsawyer to readme resources. Closes CMB2#1171
  update some more 3rd party resource items
  cleanup phpdocs for `php_to_js_dateformat`
  update 3rd party resources to include Leaflet Map field type. Props @villeristi
  Minor correction in URL
  Added new custom field type
  Tweak inline comments, and update changelog to give props for CMB2#1166
  Add CMB2_Field::get_rest_value method for sending value through several filters before sending to REST request
  WP_Http class constants were added in WP 4.5
  Doing it CMB2 way
  Fix the issue in WP prior to 4.7
  Add Switch Button field type to resources. Closes CMB2#1151
  make remove_default_tax_metaboxes method public so it may be called by hooks
  Call remove_default_tax_metaboxes from any type of post_hooks
  Add Props for CMB2#1142
  Update the draggable state's border style
  Fix docblock for CMB2_Type_Base::__call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants