Fix repeating fields within repeating groups by changing regex depending on context#1047
Merged
jtsternberg merged 1 commit intoCMB2:trunkfrom Nov 13, 2017
daggerhart:fix-repeating-field-in-group
Merged
Fix repeating fields within repeating groups by changing regex depending on context#1047jtsternberg merged 1 commit intoCMB2:trunkfrom daggerhart:fix-repeating-field-in-group
jtsternberg merged 1 commit intoCMB2:trunkfrom
daggerhart:fix-repeating-field-in-group
Conversation
Member
|
Nice, thanks! |
jtsternberg
added a commit
that referenced
this pull request
Nov 13, 2017
jtsternberg
added a commit
that referenced
this pull request
Nov 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1035 and #348. Possibly related to #712 and others.
Changes proposed in this pull request
Pass the
groupboolean intocmb.elReplacementsso it can know which index to replace for new Name and new IDs.When a new group is added, fix the name and ID attributes on the hidden
.empty-rows so that the next "Add Row" has the correct attributes.