Skip to content

Fix JS to prevent meta keys with | or / from breaking file fields #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtsternberg merged 2 commits into from
Jul 31, 2017
Merged

Fix JS to prevent meta keys with | or / from breaking file fields #1003

jtsternberg merged 2 commits into from
Jul 31, 2017

Conversation

@lipemat
Copy link
Contributor

@lipemat lipemat commented Jul 28, 2017

v2.2.4 as well as tested against trunk.
Tested a few WP versions with same results.

Issue
Using a meta_key (id) for a field that is namespaced with / or | breaks the remove JS (cmb.handleRemoveMedia()) for the file field.

To Recreate:

  1. Add a field with the type of file
  2. Use a / somewhere in the id (e.g. cmb2/meta/featured)
  3. Add a file to this field
  4. Click the remove icon
  5. View the browser console to see the error. Also notice that file is not removed.

@lipemat lipemat changed the title wrap cmb.metbox().find() JS to prevent meta keys with | or / from bre… Fix JS to prevent meta keys with | or / from breaking file fields Jul 28, 2017
@jtsternberg jtsternberg merged commit 4f7c01b into CMB2:master Jul 31, 2017
@jtsternberg
Copy link
Member

jtsternberg commented Jul 31, 2017

thanks!

@jtsternberg
Copy link
Member

jtsternberg commented Jul 31, 2017

In the future, please submit pull requests to the trunk branch.

jtsternberg added a commit that referenced this pull request Jul 31, 2017
@jtsternberg
update changelog to give props for #1003
8900d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lipemat @jtsternberg