-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fails on group field if no TinyMCE present on the page #730
Comments
I'm not able to replicate this issue. Have you tested on the trunk branch? |
Using the following branch: webdevstudios/cmb2 dev-trunk 17500e9 CMB2 |
Ok, interesting. Well, as I stated, I'm not able to replicate. Not sure what I else I can do to test. |
Had similar thing on pages with custom post types that didn't have any tinyMCE fields. When trying to remove a repeatable item had that:
Highlighted spot: I assume, the problem is inside line 298 in cmb2-wysiwyg.js, which is shipped in cmb2.min.js. Fixed with loading tinymce (for those custom posts post.php, edit.php and post-new.php admin pages):
|
@decapoda you should be able to just do @jtsternberg perhaps we need to add |
@tw2113 Yep, tried it both ways (as |
This should be good. Please test the trunk branch. Unfortunately I just pushed a release today, so will be a bit before this is released (unless I get a lot of reports of this issue). But you should be safe to use trunk as the only difference from master is this change. |
Yep, it's all good with the trunk version, thanks @jtsternberg |
Awesome to hear. |
Issue:
I have a CPT which is just title, excerpt and a CMB metabox containing a repeatable group field.
In this situation, remove doesn't work on group field -- throws a JS error in cmb2.min.js:
Line 382 ReferenceError: Can't find variable: tinyMCE
With a WYSIWYG editor present on the CPT, remove on the group field works as expected.
CMB2 Field Registration Code:
The text was updated successfully, but these errors were encountered: