Fix bug where object_type was not required for edit/delete requests (it should be)

jtsternberg · jtsternberg · commit f9bde33e475e · 2016-09-08T12:19:37.000-05:00
diff --git a/includes/CMB2_REST_Controller_Fields.php b/includes/CMB2_REST_Controller_Fields.php
@@ -156,7 +156,7 @@ public function delete_field_value( $request ) {
 	 */
 	public function modify_field_value( $activity, $field ) {
 
-		if ( ! $this->request['object_id'] && ! $this->request['object_type'] ) {
+		if ( ! $this->request['object_id'] || ! $this->request['object_type'] ) {
 			return new WP_Error( 'cmb2_rest_modify_field_value_error', __( 'CMB2 Field value cannot be modified without the object_id and object_type parameters specified.', 'cmb2' ), array( 'status' => 400 ) );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public function delete_field_value( $request ) {`
`156`	`156`	`*/`
`157`	`157`	`public function modify_field_value( $activity, $field ) {`
`158`	`158`
`159`		`- if ( ! $this->request['object_id'] && ! $this->request['object_type'] ) {`
	`159`	`+ if ( ! $this->request['object_id'] \|\| ! $this->request['object_type'] ) {`
`160`	`160`	`return new WP_Error( 'cmb2_rest_modify_field_value_error', __( 'CMB2 Field value cannot be modified without the object_id and object_type parameters specified.', 'cmb2' ), array( 'status' => 400 ) );`
`161`	`161`	`}`
`162`	`162`