Better generated array key for cached fields, fixes issue where wrong field is found. Fixes #1405

jtsternberg · jtsternberg · commit d5fdc346c660 · 2021-02-24T16:15:43.000-05:00
diff --git a/includes/CMB2.php b/includes/CMB2.php
@@ -1383,7 +1383,7 @@ public function get_field( $field, $field_group = null, $reset_cached = false )
 
 		list( $field_id, $sub_field_id ) = $ids;
 
-		$index = implode( '', $ids ) . ( $field_group ? $field_group->index : '' );
+		$index = implode( '|', $ids ) . ( $field_group ? '|' . $field_group->index : '' );
 
 		if ( array_key_exists( $index, $this->fields ) && ! $reset_cached ) {
 			return $this->fields[ $index ];
