Make the Title type handle extra args. Merge pull request #656 from pixelgrade/trunk.

jtsternberg · jtsternberg · commit c1718129c5cb · 2016-06-03T13:59:59.000-04:00
Squashed commit of the following: commit d3dad17ad8a97c50134dcb865b47cf4920458239 Author: Justin Sternberg <justin@dsgnwrks.pro> Date: Fri Jun 3 13:52:49 2016 -0400 Clean up commit 8b94b02 Author: Vlad Olaru <vlad.olaru@pixelgrade.com> Date: Fri Jun 3 10:30:49 2016 +0300 Removed the $args for good commit 09e83ff Author: Vlad Olaru <vlad.olaru@pixelgrade.com> Date: Thu Jun 2 21:29:31 2016 +0300 Removed the $args and bad slash for the title field commit c6c2b1f Author: Vlad Olaru <vlad.olaru@pixelgrade.com> Date: Thu Jun 2 09:52:13 2016 +0300 Added PHPDoc for the title type render function commit 1e6369d Author: Vlad Olaru <vlad.olaru@pixelgrade.com> Date: Thu Jun 2 09:38:14 2016 +0300 Make the Title type handle extra args Currently, the Title type didn't take into consideration extra arguments like 'attributes'. Now it does.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
 * Implement CMB2_Ajax as a singleton. Props [jrfnl](https://github.com/jrfnl) ([#602](https://github.com/WebDevStudios/CMB2/pull/602)).
 * CMB2 is now a lot more intelligent about where it is located in your installation. This update should solve almost all of the reasons to use the `'cmb2_meta_box_url'` filter (thought it will continue to work as expected). ([#27](https://github.com/WebDevStudios/CMB2/issues/27), [#118](https://github.com/WebDevStudios/CMB2/issues/118), [#432](https://github.com/WebDevStudios/CMB2/issues/432), [related wiki item](https://github.com/WebDevStudios/CMB2/wiki/Troubleshooting#cmb2-urls-issues))
 * Add `classes` and `classes_cb` CMB2 box params which allows you to add additional classes to the cmb-wrap. The `classes` parameter can take a string or array, and the `classes_cb` takes a callback which returns a string or array. The callback will receive `$cmb` as an argument. These classes are also passed through a new filter, `'cmb2_wrap_classes'`, which receives the array of classes as the first argument, and the CMB2 object as the second. Reported/requested in [#364](https://github.com/WebDevStudios/CMB2/issues/364#issuecomment-213223692).
+* Make the `'title'` field type accept extra arguments. Props [@vladolaru](https://github.com/vladolaru), [@pixelgrade](https://github.com/pixelgrade) ([#656](https://github.com/WebDevStudios/CMB2/pull/656)).
 
 
 ### Bug Fixes
diff --git a/includes/types/CMB2_Type_Title.php b/includes/types/CMB2_Type_Title.php
@@ -12,6 +12,10 @@
  */
 class CMB2_Type_Title extends CMB2_Type_Base {
 
+	/**
+	 * Handles outputting an 'title' element
+	 * @return string Heading element
+	 */
 	public function render() {
 		$a = $this->parse_args( 'title', array(
 			'tag'   => $this->field->object_type == 'post' ? 'h5' : 'h3',
@@ -21,7 +25,7 @@ public function render() {
 		) );
 
 		return $this->rendered(
-			sprintf( '<%1$s class="%2$s">%3$s</%1$s>%4$s', $a['tag'], $a['class'], $a['name'], $a['desc'] )
+			sprintf( '<%1$s %2$s>%3$s</%1$s>%4$s', $a['tag'], $this->concat_attrs( $a, array( 'tag', 'name', 'desc' ) ), $a['name'], $a['desc'] )
 		);
 	}
 
