Merged
Conversation
chahank
reviewed
Dec 12, 2023
| Parameters | ||
| ---------- | ||
| **kwargs | ||
| arguments for get_dataset and download_dataset |
Member
There was a problem hiding this comment.
Suggested change
| arguments for get_dataset and download_dataset | |
| arguments for get_dataset and download_dataset |
It is only download_dataset right?
Collaborator
Author
There was a problem hiding this comment.
Yes. The ones for download_dataset are explicitly separated and all the others are submitted to get_dataset.
Member
|
I am a bit confused by the need of this new method. Overall, the |
Collaborator
Author
|
There is no need for this new method. It's nothing but a shortcut for the use case of getting a particular file from the api. So far one has to do it in two steps: ds = client.get_dataset_info(...)
_, [path] = client.download_dataset(ds, ...)now it's possible in one: path = client.get_dataset_file(...) |
Member
|
Good for me, just need to resolve the conflict with the changelog ;). |
…t_file # Conflicts: # CHANGELOG.md
Member
|
good for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
get_dataset_file, which combines get_dataset_info and download_dataset, thus reducing boilerplate code.PR Author Checklist
develop)PR Reviewer Checklist