Add shapes argument to geo_im_from_array() in climada.util.plot#805
Add shapes argument to geo_im_from_array() in climada.util.plot#805emanuel-schmid merged 4 commits intodevelopfrom
Conversation
| shapes : bool, optional | ||
| Overlay Earth's countries coastlines to matplotlib.pyplot axis. | ||
| The default is True |
There was a problem hiding this comment.
I would call this coastlines instead of shapes. Much clearer.
There was a problem hiding this comment.
Since other functioms like geo_bin_from_array(), geo_scatter_from_array(), etc, they all name them as shapes for turning on/off the plotting of coastline, I would suggest either having it as shapes in geo_im_from_array(), or renaming all relevant shapes as coastlines, to make it more consistent.
There was a problem hiding this comment.
Ok, let it be shapes then. It is a very bad name, but consistency of code is probably more important.
|
Can you please update the And could you post a picture of a plot without the |
|
|
|
Perfect. Then, please just update the CHANGELOG.md file. |
|
@yklpaul0902 : many thanks for the contribution! 😃 The failing compatibility test is unrelated and due to a (hopefully) temporary unavailability of the ECMWF ftp server. Hence: ready to merge. |
3 participants
Changes proposed in this PR:
This PR fixes geo_im_from_array#
PR Author Checklist
develop)PR Reviewer Checklist