Skip to content

Feature/centroids as gdf#787

Merged
emanuel-schmid merged 223 commits intodevelopfrom
feature/centroids_as_gdf
Apr 11, 2024
Merged

Feature/centroids as gdf#787
emanuel-schmid merged 223 commits intodevelopfrom
feature/centroids_as_gdf

Conversation

@chahank
Copy link
Copy Markdown
Member

@chahank chahank commented Sep 28, 2023

Changes proposed in this PR:

  • Make all the centroids data to be stored in a geodataframe attribute
  • Removes and simplifies a lot of the methods.

This is a DRAFT, and comments are welcome. Not all tests are already running through as many tests are using the centroids class even though they should not. But this will be fixed once we converge to a final result.

This pull request is getting close to review-ready, pending some open discussion points (see below).

PR Author Checklist

PR Reviewer Checklist

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants