Fix empty data frame concatenation in emdat_impact_yearlysum#783
Merged
emanuel-schmid merged 4 commits intodevelopfrom Sep 20, 2023
Merged
Fix empty data frame concatenation in emdat_impact_yearlysum#783emanuel-schmid merged 4 commits intodevelopfrom
emanuel-schmid merged 4 commits intodevelopfrom
Conversation
This avoids creating an empty dataframe.
peanutfun
approved these changes
Sep 19, 2023
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
@emanuel-schmid I updated the code not to use localization in the empty dataframe but to instead use DataFrame.from_records to avoid having an empty data frame at any point in time. Also, the iteration now only runs over the variable data, and not over the "static" data which can just be added in the end. The tests still run through. Please re-review and merge at your convenience 😇
Collaborator
Author
|
🤩 neat! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impact_data.emdat_impact_yearlysumused to concatenate empty data frames, starting with an empty one and then iteratively adding non-empty ones. This triggers a deprecation warning in pandas >= 2.1.Changes proposed in this PR:
This PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist