Fix bug in centroids natural earth feature test#768
Merged
emanuel-schmid merged 3 commits intodevelopfrom Aug 10, 2023
Merged
Conversation
* Pass argument as list. * Make sure `allclose` does not throw a broadcasting error.
Member
Author
|
@emanuel-schmid The pipeline error message (see https://github.com/CLIMADA-project/climada_python/runs/15783776821) only occurs for cartopy v0.22, because the cartopy functions now return a |
Collaborator
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
allclosecould also throw errors if the arrays had a wrong size, but this was not accounted for)The original test incorrectly checked for a
ValueError: Thenatural_earthmethod would return a string (which was iterable), and aValueErrorwas thrown because a file could not be read from a single character...This PR fixes the broken pipeline in
developPR Author Checklist
develop)PR Reviewer Checklist