Feature/order samples unsequa#766
Conversation
|
Note: tests for petals fail due to the landslide module. This is unrelated to this PR.... |
|
@chahank Where in the notebook are the added examples? The table of contents is the same between the two versions. |
|
It is all the "advanced examples" at the bottom. I do not know why the sections do not show up in the t.o.c., I will have to fix this. Thank! |
timschmi95
left a comment
timschmi95
left a comment
There was a problem hiding this comment.
Without having used the unsequa module I think the the point comes across how one can (1) share an input parameter among multiple input variables and (2) using a global variable to avoid reloading files.
But a second reviewers opinion, who has used the unsequa module, is needed as I didn't follow the details in the code.
Regarding layout, if there is an option the not print the details (e.g. Cost Benefit table) for each variable combination it would improve the readability of the tutorial.
Lastly, would pulling the latest changes from the target branch feature/unsequa_multiprocessing fix the failing tests as they seem to pass in PR #763 ?
climada/engine/unsequa/unc_output.py
Outdated
| self.samples_df = samples_df | ||
| self.unit = unit | ||
|
|
||
| def order_samples(self, by): |
There was a problem hiding this comment.
The docstring has the argument name 'by_unc_params' instead of 'by'.
|
Thanks! For the printing from cost benefit, this is unfortunately backed in the module at the moment. But since this will be rewritten in the coming year, we should be able to solve this. For the tutorial I can simply remove it. And the failing test is puzzling, as it is completely unrelated. I will see to fix it. |
chahank
changed the base branch from
feature/unsequa_multiprocessing
to
develop
chahank
changed the base branch from
develop
to
feature/unsequa_multiprocessing
* Update pandas iteritems to items * Change pd append to concat * Fix minimal chunksize at 1 * Remove not needed parallel pool chunksize argument * Remove global matplotlib styles * Remove deprecated tot_value from unsequa * Add chunked version of parallel computing * Remove deprecated numpy vstack of objects * Feature/order samples unsequa (#766) * Allow to set loglevel * Add method to sort samples * Add advanced examples for unsequa * Remove logging control * Remove unecessary output prints * Update CHANGELOG.md --------- Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: emanuel-schmid <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>
2 participants
Changes proposed in this PR:
Note: this pull requests uses the loglevel from #765 . All changes not in the tutorial file are due to the other pull requests. Please merge #765 first.PR Author Checklist
develop)PR Reviewer Checklist