Skip to content

Set save_mat=False#746

Merged
chahank merged 2 commits intodevelopfrom
bugfix/unsequa_save_mat_true
Jul 6, 2023
Merged

Set save_mat=False#746
chahank merged 2 commits intodevelopfrom
bugfix/unsequa_save_mat_true

Conversation

@chahank
Copy link
Copy Markdown
Member

@chahank chahank commented Jul 5, 2023 •
edited
Loading

Changes proposed in this PR:

  • This sets the variable ImpactCalc.impact(save_mat=False) to False in the unsequa module only. Since the change to the ImpactCalc class, the default was changed from False to True, thus it needs to be set explicitly now. This is important as it cost memory and computation time, while the information cannot be processed in the unsequa module at the moment.

PR Author Checklist

PR Reviewer Checklist

@chahank chahank requested a review from peanutfun July 5, 2023 15:24
@chahank
Copy link
Copy Markdown
Member Author

chahank commented Jul 5, 2023

If you accept the fix, I will update the changelog.

peanutfun
peanutfun requested changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chahank Can you clarify in the PR description that this only affects the Unsequa module? Also, a Changelog entry is missing 🙃 Apart from that, everything looks good! 👌

@chahank chahank merged commit b4cafc1 into develop Jul 6, 2023
@emanuel-schmid emanuel-schmid deleted the bugfix/unsequa_save_mat_true branch August 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peanutfun peanutfun peanutfun requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chahank @peanutfun