Conversation
Member
|
@NicolasColombi something is off here. You reverted your original commit, so there are no changes in this branch. |
This reverts commit 208a076.
Member
|
The changes in the first commit look good and the tests are passing on my machine. I'll handle this and merge immediately, as it might clash with some changes introduced tomorrow. |
peanutfun
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Move lazy unittest to the integration folder.
List of tests moved:
This PR decrease the cost of unittest by around 27s. All tests are placed in the integration folder in the new file
test_engine.py, except for one plotting function which has his place in:test_plot.pyAs a consequence of moving tests, 5 Pylint warnings are transfered from
test_unsequa.pytotest_plot.pyPR Author Checklist
develop)PR Reviewer Checklist