You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a parameter additional_variables to the TCTracks.from_ibtracs_netcdf function that allows users to have additional IBTrACS data fields be included in the TCTracks object.
This is great! Looks good, reads well, and everything works.
Only one remark: the additional variables include a few numeric fields (iso_time, wmo_wind, wmo_pres, dist2land, storm_speed, storm_dir). None of these are interpolated when interpolate_missing = True. Do we want to extend the code to interpolate missing values here or leave that to the user?
Only one remark: the additional variables include a few numeric fields (iso_time, wmo_wind, wmo_pres, dist2land, storm_speed, storm_dir). None of these are interpolated when interpolate_missing = True. Do we want to extend the code to interpolate missing values here or leave that to the user?
These variables are not reported variables, but are provided by IBTrACS as a courtesy to users, e.g. dist2land, storm_speed, storm_dir. They never have missing values as far as I understand it. For wmo_wind and wmo_pres, I think that nobody should use these. If somebody is interested in those values, they should use the provider="official" feature.
The documentation of interpolate_missing includes a complete list of variables that are affected by this setting, and I think that's clear enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
additional_variablesto theTCTracks.from_ibtracs_netcdffunction that allows users to have additional IBTrACS data fields be included in theTCTracksobject.This PR fixes #674 and replaces #646
PR Author Checklist
develop)PR Reviewer Checklist