Merged
Conversation
NOTE: Revert this change once the Jenkins environment is updated
chahank
reviewed
Jun 13, 2023
| .PHONY : install_test | ||
| install_test : ## Test installation was successful | ||
| python tests_install.py report | ||
| pytest $(PYTEST_JUNIT_ARGS) climada/engine/test/test_cost_benefit.py \ |
Member
There was a problem hiding this comment.
Note for the future: we should probably make a better install test. If there is already one around, I would propose to switch now.
Member
Author
There was a problem hiding this comment.
Do you have a particular integration test in mind that would be suitable for that?
Member
|
Looks all very reasonable and useful. However, I cannot gauge the code on a technical level. @emanuel-schmid : could you please have a look and confirm the review? |
# Conflicts: # CHANGELOG.md
Collaborator
emanuel-schmid
left a comment
emanuel-schmid
left a comment
There was a problem hiding this comment.
👍 looks good to me
Collaborator
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
pytestfor executing tests. This relieves us from relying onXMLRunnerand the testing scripts when executing unit and integration tests. (XMLRunnercannot be removed from the dependencies yet because it is used in the scripts for testing the notebooks and data API).makeis needed to run the tests exactly as they are in the CI pipeline.NOTE: After review, please remove the line installing the new test dependencies and add these to the Jenkins test environment instead: https://github.com/CLIMADA-project/climada_python/pull/726/files#diff-efc5a58368476423c7df00e553fe2c5ba301550f96c3cc5a970aa9a51c9e4eddR26
PR Author Checklist
develop)[ ] Tests updatedPR Reviewer Checklist