Feature/haz type in step impf#675
Merged
leonie-villiger merged 10 commits intodevelopfrom Mar 29, 2023
Merged
Conversation
Collaborator
leonie-villiger
left a comment
leonie-villiger
left a comment
There was a problem hiding this comment.
Thank you for implementing the keyword argument haz_type into _ImpactFunc_´s classmethods from_step_impf and from_sigmoid_imp ! Please find some minor comments in the Files changed.
Co-authored-by: leonie-villiger <[email protected]>
Co-authored-by: leonie-villiger <[email protected]>
Member
Author
|
Thanks a lot for the thorough review! I think I addressed all points. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
PR Author Checklist
develop)PR Reviewer Checklist