Merged
Conversation
Add 3 test to check that the plotting functions of climada/entity/exposure/base.py do not throw any errors when they are called. Specifically, the functions tested are: 1) plot_scatter 2) plot_raster 3) plot_basemap
Add test that check that the function plot_rp_intensity(), present in climada/hazard/base.py, do not throw errors when it is called.
Add test to check that plot() in climada/entity/disc_rates/base.py do not raise errors when called.
1) Add test for centroid plots. 2) Add a test to check that the right title is displayed when using plot_rp_intensity() to plot hazard exceedance intensity
peanutfun
requested changes
Jan 6, 2023
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
Very good, thanks a lot for raising the pull request! I just found two minor things to change.
peanutfun
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
PR Author Checklist
develop)PR Reviewer Checklist