coord_on_land: fix buffer for global grids#542
Merged
emanuel-schmid merged 1 commit intodevelopfrom Oct 7, 2022
Merged
Conversation
11 tasks
chahank
approved these changes
Oct 7, 2022
Member
chahank
left a comment
chahank
left a comment
There was a problem hiding this comment.
Great, thanks for the fix!
@emanuel-schmid Should this maybe go directly into main as it is a bug?
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
u_coord.coord_on_land, use the more stablelatlon_boundsfunction to add a buffer around the specified coordinates to avoid problems with global grids where the buffer would increase the bounds beyond 360 degrees in width.This PR fixes issue #539
PR Author Checklist
develop)PR Reviewer Checklist