Skip to content

Feature/ctx sources deprecation#517

Merged
emanuel-schmid merged 5 commits intodevelopfrom
feature/ctx-sources-deprecation
Jul 20, 2022
Merged

Feature/ctx sources deprecation#517
emanuel-schmid merged 5 commits intodevelopfrom
feature/ctx-sources-deprecation

Conversation

@emanuel-schmid
Copy link
Copy Markdown
Collaborator

Changes proposed in this PR:

  • Replace contextily.sources with contextily.providers, as suggested in the deprecation warning of contextily 1.1
  • use contextily.providers rather than hard coded urls as default arguments for plotting methods

This PR fixes issue #319

Pull Request Checklist

  • Correct target branch selected (if unsure, select develop)
  • Source branch up-to-date with target branch
  • Docs updated
  • Tests updated
  • Tests passing
  • No new linter issues

# Conflicts:
#	climada/engine/impact.py
@frqqyy
Copy link
Copy Markdown
Collaborator

frqqyy commented Jul 16, 2022

This PR solves the issue #465 effectively. Thank you!

@emanuel-schmid emanuel-schmid merged commit 373ecae into develop Jul 20, 2022
@emanuel-schmid emanuel-schmid deleted the feature/ctx-sources-deprecation branch July 20, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants