hotfix: bug in bounding_box_from_countries#1018
Merged
ValentinGebhart merged 4 commits intodevelopfrom Mar 6, 2025
Merged
Conversation
ValentinGebhart
changed the title
peanutfun
requested changes
Mar 5, 2025
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
The case is obviously not covered by a test, or else this would have been noticed before. The linter also complains about that. Could you add a test involving a polygon instead of a multipolygon? But please check first if you cannot simply iterate over the coords attribute of MultiPolygon, too.
peanutfun
approved these changes
Mar 6, 2025
peanutfun
approved these changes
Mar 6, 2025
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
The code looks very nice now! I approve under the condition that you remove (now unused) the import of Polygon, as Jenkins complains. Then you can merge!
emanuel-schmid
added a commit
that referenced
this pull request
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
util.coordinates.bounding_box_from_countries, if the country is a polygon and not a multipolygon, e.g., isocode = 'CHE'.PR Author Checklist
develop)PR Reviewer Checklist