Conversation
|
there is a test release on test.pypi.org:
|
|
Most failing tests are because the climada_python develop branch has deviated. There is one that fails because I didn't move one of the files, mistaking it for obsolete. |
There was a problem hiding this comment.
I installed the test release and the data is copied correctly. Well done! I just have a few technical comments to the setup.py, but since it works, we do not need to dig too deeply into it.
I also ran a couple of tests on the installed version and most seem to work out. However, I found an issue: The tc_rainfield.py tries to import climada.util.tag (see https://github.com/CLIMADA-project/climada_petals/blob/develop/climada_petals/hazard/tc_rainfield.py#L34), but this has never existed in Climada. How did this escape our tests?
Edit: I just saw that #88 fixes this particular issue, so all good here
|
| These issues are fixed by #88 and #89, right? Then we should merge them first. Not if we want to make a patch release that just solves issue #86. This PR targets the main branch, #88 and #89 develop. Since Climada 4 is on the horizon we shouldn't spend too much time here. Just fix the pip release and then make a Conda release, I say. |
|
The changes to the tags in Core are not released yet, right? Then I am fine with merging this now. The tests should then pass when we test the released versions against each other 🤞 |
2 participants
Changes proposed in this PR:
This PR fixes #86
PR Author Checklist
develop)PR Reviewer Checklist