remove tags from hazard classes#88
Merged
emanuel-schmid merged 6 commits intodevelopfrom Aug 25, 2023
Merged
Conversation
peanutfun
approved these changes
Aug 21, 2023
Member
peanutfun
left a comment
peanutfun
left a comment
There was a problem hiding this comment.
Looks good! I only suggest to improve the Changelog entry.
| from climada.hazard.base import Hazard | ||
| from climada.hazard.centroids import Centroids | ||
| import climada.util.coordinates as u_coord | ||
| from climada.util.tag import Tag |
Member
There was a problem hiding this comment.
How did this work before? I don't see a climada/util/tag.py module in any of the recent releases
Contributor
Author
There was a problem hiding this comment.
after release 3.3, hazard.tag and entity.tag have been merged
Comment on lines
-280
to
-283
| yearrange=TARGET_YEARRANGE, yearrange_ref=REFERENCE_YEARRANGE, | ||
| gh_model=None, cl_model=None, | ||
| scenario='historical', scenario_ref='historical', soc='histsoc', | ||
| soc_ref='histsoc', fn_str_var=FN_STR_VAR, keep_dis_data=False): |
Member
There was a problem hiding this comment.
Curious, that all of this information was only put into the tag 🤔
CHANGELOG.md
Outdated
Comment on lines
+20
to
+21
| - several adaptations have been necessary because of the `Tag` class being removed from the CLIMADA core package: | ||
| [#88](https://github.com/CLIMADA-project/climada_petals/pull/88) |
Member
There was a problem hiding this comment.
I suggest to put this into the "Removed" category:
### Removed
- `tag` attribute from hazard classes [#88](https://github.com/CLIMADA-project/climada_petals/pull/88)
Contributor
Author
|
🙌 thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This is part of the overall climada refactoring to remove the Tag classes.
This PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist