Skip to content

Only assign csr matrices to Hazard objects#129

Merged
peanutfun merged 2 commits intodevelopfrom
ensure-csr-matrix-assignment
Jun 24, 2024
Merged

Only assign csr matrices to Hazard objects#129
peanutfun merged 2 commits intodevelopfrom
ensure-csr-matrix-assignment

Conversation

@peanutfun
Copy link
Copy Markdown
Member

@peanutfun peanutfun commented Jun 14, 2024

Changes proposed in this PR:

  • Use intermediate variables if LIL matrices are used.
  • Write all-zero fraction matrix instead of all-ones (all-zero fractions are treated as ones).

This PR fixes compatibility issues arising from CLIMADA-project/climada_python#893

PR Author Checklist

PR Reviewer Checklist

* Use intermediate variables if LIL matrices are used.
* Write all-zero fraction matrix instead of all-ones
  (all-zero fractions are treated as ones).
@peanutfun peanutfun requested a review from chahank June 21, 2024 13:32
Copy link
Copy Markdown
Member

@chahank chahank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@peanutfun peanutfun merged commit 13fd366 into develop Jun 24, 2024
peanutfun added a commit that referenced this pull request Jun 25, 2024
* Fix matrix assignment in WildFire
  (leftover from #129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants