Merged
Conversation
…m pointer_file modification
dabail10
approved these changes
Oct 30, 2024
anton-seaice
approved these changes
Oct 30, 2024
| else | ||
| if (my_task == master_task) then | ||
| open(nu_rst_pointer,file=pointer_file) | ||
| open(nu_rst_pointer,file=pointer_file, status='old') |
Contributor
There was a problem hiding this comment.
We could / should probably do error checking on this open ? @apcraig ?
Anyway - its unrelated to this change
Contributor
Author
There was a problem hiding this comment.
That's exactly why I added the status="old", the fortran error message provided if the file doesn't exist should be adequate.
apcraig
reviewed
Oct 31, 2024
Contributor
apcraig
left a comment
apcraig
left a comment
There was a problem hiding this comment.
Please check that io_netcdf is consistent with io_pio with respect to recent changes in rpointer implementation.
Contributor
|
I believe everything here is in CESMCOUPLED ifdefs and so should not be added to io_netcdf or io_pio. |
Contributor
|
Oh yes - should be update to match withstatus='old'
|
dabail10
approved these changes
Oct 31, 2024
apcraig
approved these changes
Nov 5, 2024
mvdebolskiy
pushed a commit
to mvdebolskiy/CICE
that referenced
this pull request
Mar 11, 2025
With the change in cesm3_cice6_5_0_9 the correct cesm pointer_file name is written to the namelist file and so it is no longer required to append the instance number in a multi instance case. * add status feature to open existing file, remove no longer needed cesm pointer_file modification * add status for pointer_file open in netcdf
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Short (1 sentence) summary of your PR:
add status feature to open existing file, remove no longer needed cesm pointer_file modification
Developer(s):
Jim Edwards (NCAR)
Suggest PR reviewers from list in the column to the right.
Dave Bailey
Please copy the PR test results link or provide a summary of testing completed below.
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
With the change in cesm3_cice6_5_0_9 the correct cesm pointer_file name is written to the namelist file and so it is no longer required to append the instance number in a multi instance case.