Skip to content

Optionally rotate wind/stress from to computational grid (from true north)#473

Merged
apcraig merged 3 commits intoCICE-Consortium:masterfrom
mhrib:rotate_wind
Jun 23, 2020
Merged

Optionally rotate wind/stress from to computational grid (from true north)#473
apcraig merged 3 commits intoCICE-Consortium:masterfrom
mhrib:rotate_wind

Conversation

@mhrib
Copy link
Copy Markdown
Contributor

@mhrib mhrib commented Jun 22, 2020 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • [x ] Short (1 sentence) summary of your PR:
    Optional rotate wind vectors to computational grid (default)
  • Developer(s):
    Mads Hvid Ribergaard, DMI
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Able to merge. These branches can be automatically merged.
  • How much do the PR code changes differ from the unmodified code?
    • [x ] bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • [x ] No
  • Does this PR add any new test cases?
    • Yes
    • [ x] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • [x ] Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • [x ] Please provide any additional information or relevant details below:

A completely other change within this pull request:

  • Also printout seconds, if a reading error occur reading "hycom"-forcing within ice_forcing.F90

eclare108213
eclare108213 requested changes Jun 22, 2020
View reviewed changes
@apcraig apcraig requested a review from eclare108213 June 22, 2020 21:26
@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Jun 22, 2020

How much testing has been done? Are we confident it's all bit-for-bit?

eclare108213
eclare108213 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much easier to understand at a glance, thank you.

@mhrib
Copy link
Copy Markdown
Contributor Author

mhrib commented Jun 23, 2020 •
edited
Loading

@apcraig w.r.t. bit-for-bit. Depending on rotate_wind option (true/false) it will skip the rotation of wind/stress. So it assumes, that the provided forcing is rotated correctly and exactly like the default inline rotation.

@mhrib mhrib closed this Jun 23, 2020
@mhrib mhrib reopened this Jun 23, 2020
@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Jun 23, 2020

@mhrib I understand what the code is supposed to do. I just want to confirm that you have compiled and run this code, and that the default setting produces bit-for-bit results. That information was not included in the PR information yet. Thanks.

@apcraig apcraig merged commit f2dc42c into CICE-Consortium:master Jun 23, 2020
@mhrib
Copy link
Copy Markdown
Contributor Author

mhrib commented Jun 24, 2020

@mhrib I understand what the code is supposed to do. I just want to confirm that you have compiled and run this code, and that the default setting produces bit-for-bit results. That information was not included in the PR information yet. Thanks.

@apcraig Sorry, I did not perform the test (which I always should do!). Now tested with intel compiler on GX3 grid (4x4) running for one day (24 steps) using the same ice_in file without rotate_wind defined (ie. set to default value = .true.): md5sum's on restart-files are equal.
fde1877b90dcc38e160d3ee1a520217c restart/iced.1998-01-02-00000.nc_new
fde1877b90dcc38e160d3ee1a520217c restart/iced.1998-01-02-00000.nc_org

@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Jun 24, 2020

Thanks @mhrib, I also ran a full test suite last night and everything looks good. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash#3fedc78b1b012f8bd6c0fde7c1b41e79b9db63a9

@mhrib mhrib deleted the rotate_wind branch October 7, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@apcraig apcraig apcraig approved these changes

Assignees

No one assigned

Labels

Forcing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhrib @apcraig @eclare108213