Update NOAA ports, hera and orion#449
Merged
apcraig merged 9 commits intoCICE-Consortium:masterfrom May 26, 2020
Merged
Conversation
eclare108213
approved these changes
May 22, 2020
Contributor
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
Looks fine to me. It would be best if @rgrumbine reviews this one.
rgrumbine
approved these changes
May 26, 2020
Contributor
rgrumbine
left a comment
rgrumbine
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update NOAA ports, hera and orion
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#26511f32946e2e59f1e527e24d927c54b78723e3
longer bgc tests fail on orion, issue TBD.
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
Updated hera port
Added orion port. Note that modules are not working in csh on orion so they need to be loaded manually before running cice.setup.
Removed phase2 and theia