Update wave_spec_frac filename implementation and update icepack#417
Merged
apcraig merged 2 commits intoCICE-Consortium:masterfrom Mar 13, 2020
Merged
Update wave_spec_frac filename implementation and update icepack#417apcraig merged 2 commits intoCICE-Consortium:masterfrom
apcraig merged 2 commits intoCICE-Consortium:masterfrom
Conversation
eclare108213
approved these changes
Mar 13, 2020
Contributor
Author
|
@lettie-roach, this modification updates the wave_spec_frac filename implementation, so now that namelist defines the path and filename. It should be easier to use with that change. This PR also brings in the lastest Icepack changes that include the update to the random wavespec algorithm. If you have a chance to review, that would be great. If not, I'll probably merge today to include in weekend testing. Thanks! |
lettie-roach
approved these changes
Mar 13, 2020
Contributor
|
Looks good to me, thanks Tony
…On Fri, 13 Mar 2020 at 09:54, Tony Craig ***@***.***> wrote:
@lettie-roach <https://github.com/lettie-roach>, this modification
updates the wave_spec_frac filename implementation, so now that namelist
defines the path and filename. It should be easier to use with that change.
This PR also brings in the lastest Icepack changes that include the update
to the random wavespec algorithm. If you have a chance to review, that
would be great. If not, I'll probably merge today to include in weekend
testing. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#417 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIYTCKTPELI4W5ZD5IMISLRHJQMTANCNFSM4LGXZVEQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update wave_spec_frac filename and update Icepack
apcraig
Tested a couple days ago, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#7e2a1d99974d21c28a0983721a2453fbf14adbfe. Retesting again with clean sandbox produces same results, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#e3ce8dcf9b088ce90b4b85dda1e67305064d2c52
Addresses #415