Skip to content

Fixed ibtypee typo bug in map_mesh_properties#298

Merged
WPringle merged 2 commits intoCHLNDDEV:Projectionfrom
tgasher:tgasher-patch-1-ibtypeeTypoBugInMap_mesh_properties
Aug 11, 2023
Merged

Fixed ibtypee typo bug in map_mesh_properties#298
WPringle merged 2 commits intoCHLNDDEV:Projectionfrom
tgasher:tgasher-patch-1-ibtypeeTypoBugInMap_mesh_properties

Conversation

@tgasher
Copy link
Copy Markdown
Contributor

@tgasher tgasher commented Aug 11, 2023

An incorrect reference to ibtype causes an error. It's within code working on the open boundaries, so it appears it should be ibtypee. Changing it fixed the error, in my case. Though I'm unsure what test cases to compare with, since this seems to be a segment of code that's not been touched before.

An incorrect reference to ibtype causes an error.  It's within code working on the open boundaries, so it appears it should be ibtypee.
Copy link
Copy Markdown
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding. Looks good

Copy link
Copy Markdown
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to changelog in README

@tgasher
Copy link
Copy Markdown
Contributor Author

tgasher commented Aug 11, 2023

Done.

@WPringle
Copy link
Copy Markdown
Collaborator

Done.

Cheers!

@WPringle WPringle merged commit f0c9257 into CHLNDDEV:Projection Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants