read in existing auxiliary files into msh obj, updates to make_bc#287
Merged
krober10nd merged 9 commits intoProjectionfrom Feb 23, 2024
Merged
read in existing auxiliary files into msh obj, updates to make_bc#287krober10nd merged 9 commits intoProjectionfrom
krober10nd merged 9 commits intoProjectionfrom
Conversation
…ect, this is called from when the kwarg is used, but now we can also use this feature without calling through msh() function
…rwise it converted the offset_values to integer)
…lling fro TPXO9-atlas solutions, (2( adding option for min_depth to be passed which is used as a lower limit of the depth used to divide tidal transport velocities by
Collaborator
Author
|
Sponge example: |
krober10nd
approved these changes
Feb 21, 2024
Collaborator
krober10nd
left a comment
There was a problem hiding this comment.
I like the ability to read in aux files using the msh.read() perhaps this could be added to the README as a code snippet and a short couple sentences?
| ### Unreleased (on current HEAD of the Projection branch) | ||
| ## Added | ||
|
|
||
| - Added new function in `msh` called `remesh_patch` to remesh within specified polygonal domains and insert back into parent mesh. |
Collaborator
There was a problem hiding this comment.
Please preserve the prior recently added items on the checklist.
Collaborator
|
The only other comment pending is regarding preserving the previous entries in the changelog. Otherwise good to go. |
Longer description of msh.read() function additions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some additions for sponge zone construction, reading auxiliary files, writing offset63, swanoutput namelist, update Make_f5354 help and min_depth option.